Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add storageclass to eventtailer chart #1045

Merged
merged 2 commits into from
Jul 6, 2022
Merged

feat: add storageclass to eventtailer chart #1045

merged 2 commits into from
Jul 6, 2022

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Jul 6, 2022 •
edited
Loading

Q A
Bug fix? no
New feature? yes
API breaks? yes
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Add the storageClass option to specify the PVC provisionner in the EventTailer chart entry.

Why?

This allows theuse of a non default storage class.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@aslafy-z aslafy-z marked this pull request as ready for review July 6, 2022 20:07
@ahma ahma self-requested a review July 6, 2022 21:15
ahma
ahma approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahma ahma merged commit 275eaae into master Jul 6, 2022
@tarokkk tarokkk deleted the aslafy-z-patch-2 branch July 19, 2022 08:14
This was referenced Jul 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslafy-z @ahma