Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extra args to logging fluentd and pass it to config check #1054

Merged
merged 2 commits into from
Jul 20, 2022
Merged

Added extra args to logging fluentd and pass it to config check #1054

merged 2 commits into from
Jul 20, 2022

Conversation

petergvizd
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
License Apache 2.0

What's in this PR?

Added extra args to logging fluentd and pass it config check
Pass env variables from logging fluentd also to config check

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@petergvizd petergvizd force-pushed the feature/added-extra-args-to-logging-fluentd branch from b76a72c to a3c8eab Compare July 19, 2022 14:12
@petergvizd petergvizd changed the title Added extra args to logging fluentd and pass it config check Added extra args to logging fluentd and pass it to config check Jul 19, 2022
@ahma ahma requested review from ahma and siliconbrain July 19, 2022 15:47
ahma
ahma previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm Thanks @petergvizd

siliconbrain
siliconbrain previously approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@siliconbrain siliconbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petergvizd petergvizd dismissed stale reviews from siliconbrain and ahma via 8c5b68d July 20, 2022 07:35
@petergvizd petergvizd requested review from siliconbrain and ahma July 20, 2022 07:35
ahma
ahma approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahma ahma merged commit e8e2f21 into kube-logging:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahma ahma ahma approved these changes

@siliconbrain siliconbrain Awaiting requested review from siliconbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petergvizd @siliconbrain @ahma