Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluentbit: Add support for Kube_Meta_Cache_TTL parameter #1144

Merged
merged 4 commits into from
Dec 5, 2022

Conversation

Jellyfrog
Copy link
Contributor

@Jellyfrog Jellyfrog commented Dec 1, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets /
License Apache 2.0

What's in this PR?

Adding support for another parameter from https://docs.fluentbit.io/manual/pipeline/filters/kubernetes#configuration-parameters

Why?

Currently it caches the metadata forever, so when changing a pods label it wont be reflected in the log output until fluentbit is restarted.

Additional context

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)

To Do

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2022

CLA assistant check
All committers have signed the CLA.

aslafy-z
aslafy-z previously approved these changes Dec 1, 2022
@aslafy-z aslafy-z requested a review from ahma December 2, 2022 17:12
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jellyfrog LGTM

Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jellyfrog could you please run a make manifests here ?

@Jellyfrog
Copy link
Contributor Author

@ahma fixed, please note I didnt have a chance to actually test this, I copied how the other options are exposed, and hope for the best :)

@ahma ahma merged commit 51592f7 into kube-logging:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants