add option for loki output to configure "include_thread_label" #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This exposes the
include_thread_labeloption added in 1.2.19 of the fluent-loki pluginWhy?
When using more than 1 flush_thread_count the associated thread is added as a label to each log line. This is unnecessary in some use cases and increases the cardinality of labels.
Additional context
This requires 1.2.19 of the fluent-plugin-grafana-loki and the current image
ghcr.io/banzaicloud/fluentd:v1.14.6-alpine-6only has version 1.2.18. It wasn't clear to me how this image gets updated, but since the gem version is not pinned in the Dockerfile I believe a new build of the image should pull in this new plugin version. Let me know if there is something additional that needs to be done as part of this PR.Checklist
To Do