Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move persist file next to buffers #1174

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Conversation

tarokkk
Copy link
Contributor

@tarokkk tarokkk commented Jan 31, 2023

Syslog-ng stores persist information (like buffer file path) in a persist file. In the case this file is not persisted Pod restart may spawn new buffer files and ignore old files. To prevent this we moved the persist file next to the buffers.

@tarokkk tarokkk requested review from siliconbrain and ahma January 31, 2023 18:51
ahma
ahma previously approved these changes Jan 31, 2023
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

siliconbrain
siliconbrain previously approved these changes Jan 31, 2023
@tarokkk tarokkk dismissed stale reviews from siliconbrain and ahma via 9ea2268 January 31, 2023 19:05
@ahma ahma self-requested a review January 31, 2023 19:21
@ahma ahma merged commit fbf3473 into master Jan 31, 2023
@ahma ahma deleted the syslog-ng-fix-persist-file-path branch January 31, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants