Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] mattermost plugin #1200

Merged
merged 18 commits into from
Apr 5, 2023
Merged

[feature] mattermost plugin #1200

merged 18 commits into from
Apr 5, 2023

Conversation

Sebor
Copy link
Contributor

@Sebor Sebor commented Feb 14, 2023

This PR adds support of fluentd mattermost plugin

@CLAassistant
Copy link

CLAassistant commented Feb 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Sebor
Copy link
Contributor Author

Sebor commented Feb 14, 2023

There are strange errors in CI e2e test:

# github.com/kube-logging/logging-operator/pkg/sdk/logging/api/v1alpha1
Error: pkg/sdk/logging/api/v1alpha1/output_conversion.go:28:32: cannot convert o.Spec (variable of type OutputSpec) to type v1beta1.OutputSpec
Error: pkg/sdk/logging/api/v1alpha1/output_conversion.go:40:22: cannot convert src.Spec (variable of type v1beta1.OutputSpec) to type OutputSpec

But I did not change those files

@Sebor Sebor mentioned this pull request Feb 15, 2023
Merged
@Sebor Sebor requested a review from aslafy-z February 15, 2023 13:09
@Sebor
Copy link
Contributor Author

Sebor commented Feb 16, 2023

HI @ahma, @tarokkk !
Could you review my PR?

@ahma ahma added this to the Release 4.1 milestone Feb 26, 2023
@ahma
Copy link
Contributor

ahma commented Mar 8, 2023

@Sebor could you please update this branch?

@Sebor
Copy link
Contributor Author

Sebor commented Mar 9, 2023

@Sebor could you please update this branch?

@ahma,
updated

@ahma ahma requested review from pepov and siliconbrain March 9, 2023 19:35
siliconbrain
siliconbrain previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@siliconbrain siliconbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sebor Sebor requested review from pepov and removed request for aslafy-z March 14, 2023 19:55
@pepov
Copy link
Member

pepov commented Mar 17, 2023

could you please run a fresh make generate manifests?

@Sebor
Copy link
Contributor Author

Sebor commented Mar 17, 2023

could you please run a fresh make generate manifests?

done

pepov
pepov previously approved these changes Apr 4, 2023
View reviewed changes
@pepov pepov requested a review from ahma April 4, 2023 09:22
@pepov
Copy link
Member

pepov commented Apr 4, 2023

@Sebor once we pull this in please add a pr to include this into one of the docker images (the one in this repo is only a test image)

@pepov
Copy link
Member

pepov commented Apr 4, 2023

I've added some changes to fix the errors and unblock this PR

@pepov pepov enabled auto-merge April 4, 2023 09:47
@Sebor
Copy link
Contributor Author

Sebor commented Apr 4, 2023

@Sebor once we pull this in please add a pr to include this into one of the docker images (the one in this repo is only a test image)

Is this PR enough?

@pepov
Copy link
Member

pepov commented Apr 4, 2023

@Sebor once we pull this in please add a pr to include this into one of the docker images (the one in this repo is only a test image)

Is this PR enough?

I would also add it to the v1.15 image as well

ahma
ahma approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sebor LGTM

@Sebor
Copy link
Contributor Author

Sebor commented Apr 4, 2023

Looks like it's already there

@Sebor Sebor requested a review from pepov April 4, 2023 21:55
@pepov pepov merged commit d552766 into kube-logging:master Apr 5, 2023
@Sebor Sebor deleted the feature/mattermost-plugin branch April 5, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslafy-z aslafy-z aslafy-z left review comments

@pepov pepov pepov approved these changes

@ahma ahma ahma approved these changes

@siliconbrain siliconbrain siliconbrain left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@Sebor @CLAassistant @ahma @pepov @siliconbrain @aslafy-z