Introduce NodeAgent CRD #1249
Merged
Introduce NodeAgent CRD #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahma
previously approved these changes
Mar 14, 2023
pepov
force-pushed
the
nodeagent-extract
branch
from
f9609c2 to
b68eac9
Compare
pepov
changed the title
tarokkk
previously approved these changes
Mar 21, 2023
pepov
force-pushed
the
nodeagent-extract
branch
from
38b17cb to
207d87a
Compare
…gent as a separate CRD
…ds (nodeAgents, fluentbit)
… updated based on these charts as there are generated content in it.
pepov
force-pushed
the
nodeagent-extract
branch
from
ca4114d to
6b4aa7e
Compare
pepov
force-pushed
the
nodeagent-extract
branch
from
6b4aa7e to
8c2df23
Compare
ahma
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce NodeAgent CRD and update the code to properly handle it, while preserving compatibility with the previous inline nodeagent config in the Logging resource. The new resource does not have a
namefield in the spec as it has that in the metadata.Conflicts between legacy and new nodeagents (when they have the same name) handled by logging an error but moving on with the values configured in the NodeAgent CR.
Charts have been restored under
e2e/chartsso that we can properly run the e2e tests. We should keep the charts here and synchronize to github.com/kube-logging/helm-charts before release.