-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS output plugin #796
SQS output plugin #796
Conversation
@adnan-kobir-sp Thanks for your contribution! Could you pls use secret refs. to store aws creds eg.: https://github.com/banzaicloud/logging-operator/blob/master/pkg/sdk/model/output/aws_elasticsearch.go#L86 Thanks! |
@ahma done. Thanks for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @adnan-kobir-sp !
@pepov can I get a review please? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
* feat: add aws sqs output * fix: update v1alpha1 output_types * feat: add remaining input params * fix: make generate * fix: test output order * fix: use secret refs for aws keys Co-authored-by: Ferenc HERNADI <[email protected]>
What's in this PR?
Adds SQS output plugin
Additional context
To test the implementation:
fluentd
with the addedfluent-plugin-sqs
gem and pushed up the docker image to my public repositorypkg/sdk/api/v1beta1/logging_types.go
and setDefaultFluentdImageRepository
to my public image repo temporarilyFlow
and appendedsqs-output-sample
I was able to verify that messages were successfully being populated in
some-aws-sqs-queue
queueChecklist