Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing RBAC rule for working with PrometheusRules #818

Merged
merged 1 commit into from
Sep 3, 2021
Merged

add missing RBAC rule for working with PrometheusRules #818

merged 1 commit into from
Sep 3, 2021

Conversation

siliconbrain
Copy link
Contributor

The operator cannot create PrometheusRules when enabled without this rule.

@siliconbrain
add missing RBAC rule for working with PrometheusRules
e1bcde8 
The operator cannot create PrometheusRules when enabled without this rule.
ahma
ahma approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pepov pepov mentioned this pull request Sep 3, 2021
Closed
1 task
@siliconbrain siliconbrain merged commit 5a08d9c into master Sep 3, 2021
@siliconbrain siliconbrain deleted the missing-rbac-rule-for-prometheusrules branch September 3, 2021 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@ahma ahma ahma approved these changes

@tarokkk tarokkk Awaiting requested review from tarokkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siliconbrain @pepov @ahma