Default metrics labels #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepov
force-pushed
the
default_metrics_labels
branch
from
782ccb2 to
5860532
Compare
pepov
force-pushed
the
default_metrics_labels
branch
from
0afa3ce to
f4e4a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Add default_metrics_labels for the default route with the flow id.
Why?
Because right now the default flow id is not available in the metrics when metrics is enabled for fluentd. Along with https://github.com/banzaicloud/fluent-plugin-label-router/issues/16 it actually fails and unable to process messages.