Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluentd Service Topology support #860

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fluentd Service Topology support #860

merged 2 commits into from
Oct 18, 2021

Conversation

ahma
Copy link
Contributor

@ahma ahma commented Oct 16, 2021

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #696
License Apache 2.0

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

@ahma ahma requested review from pepov and tarokkk October 16, 2021 21:36
pepov
pepov approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@pepov pepov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahma ahma force-pushed the feature/service_topologyKeys branch from 0a7896a to 66e3d1a Compare October 18, 2021 17:25
@ahma ahma merged commit ff8e4b6 into master Oct 18, 2021
@ahma ahma deleted the feature/service_topologyKeys branch October 18, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepov pepov pepov approved these changes

@bshifter bshifter bshifter approved these changes

@tarokkk tarokkk Awaiting requested review from tarokkk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Topology Support
3 participants
@ahma @pepov @bshifter