Fix panic when spec.fluentd is omitted from Logging manifest #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rich Lander <[email protected]>
|
|
… in use Signed-off-by: Rich Lander <[email protected]>
tarokkk
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rich Lander [email protected]
What's in this PR?
There were some fluentd defaults being set for the logging object in it's
SetDefaultsmethod that were outside the if-statement that checks for the presence of a fluend spec. I just nested those default setters under that if-statement.Why?
The controller panics when it tries to set attributes of a fluend spec that don't exist.
Checklist