Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging extensions transition #891

Merged
merged 3 commits into from
Jan 7, 2022
Merged

logging extensions transition #891

merged 3 commits into from
Jan 7, 2022

Conversation

bshifter
Copy link
Contributor

@bshifter bshifter commented Dec 10, 2021 •
edited by tarokkk
Loading

Q A
Bug fix? no
New feature? yes
API breaks? yes
Deprecations? no
Related tickets fix
License Apache 2.0

extensions types added
extensions controllers added
extensions helpers added
logging tests fixed
Makefile fixes

What's in this PR?

Migration of logging-extensions to public repo

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)

To Do

  • tailer webhook
  • charts

@bshifter bshifter changed the title logging extensios transition logging extensions transition Dec 10, 2021
shifter added 2 commits January 6, 2022 00:38
extensions types added
6bf24a0 
extensions controllers added
extensions helpers added
logging tests fixed
Makefile fixes
e2e fixes
04991c6
@bshifter bshifter force-pushed the logging-extensions branch from 86aacb3 to 04991c6 Compare January 5, 2022 23:41
@tarokkk tarokkk marked this pull request as ready for review January 6, 2022 09:59
siliconbrain
siliconbrain approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@siliconbrain siliconbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. feel free to ignore the suggestions as they are more about the original code than the transition itself. I gave up on reviewing the whole change half way through for the same reason. we'll fix it all eventually...

ahma
ahma approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job Thanks, LGTM

@bshifter bshifter merged commit 4218d98 into master Jan 7, 2022
@ahma ahma deleted the logging-extensions branch January 7, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siliconbrain siliconbrain siliconbrain approved these changes

@tarokkk tarokkk tarokkk approved these changes

@ahma ahma ahma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bshifter @siliconbrain @tarokkk @ahma