Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buffer max size and skip long lines to Hosttailer Filetailer #936

Conversation

nutellinoit
Copy link
Contributor

@nutellinoit nutellinoit commented Mar 2, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

Hi everyone, I added two parameters on the Filetailer Hosttailer settings:

  • Buffer_Max_Size , default to 32k, to be able to read longer lines
  • Skip_Long_Lines, default to On, to skip long lines and continue tailing logs

Why?

In my use case, i'm using the Hosttailer to read Kubernetes audit logs, and sometimes these logs are very long.

Checklist

  • Code meets the Developer Guide
  • User guide and development docs updated (if needed)
  • Related Helm chart(s) updated (if needed)

To Do

  • e2e tests

nutellinoit and others added 2 commits March 2, 2022 12:00
This parameter, On by default, will skip the lines that exceed the Buffer_Max_Size parameter

Co-Authored-By: Reuenthal767 <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Mar 2, 2022

CLA assistant check
All committers have signed the CLA.

@nutellinoit nutellinoit changed the title Feature/add buffer max size to hosttailer feat: add buffer max size and skip long lines to Hosttailer Filetailer Mar 2, 2022
Copy link
Contributor

@ahma ahma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine to me, Thanks @nutellinoit

Copy link
Contributor

@bshifter bshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahma ahma merged commit 8ec9cf9 into kube-logging:master Mar 3, 2022
@bshifter bshifter mentioned this pull request Mar 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants