Set status explicitly in the kube tag #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
reviewed
Feb 16, 2022
clux
reviewed
Feb 16, 2022
|
Yeah, good plan. We probably need to do some changes afterwards as well to get the status object patched in (kubectl doesn't apply statuses - so currently no way to verify the instance you sent) |
|
main is updated if you want to update |
done :) |
Without this, the status data won't be accessible through the generated struct fixes kube-rs#4 Signed-off-by: Flavio Percoco <[email protected]>
clux
approved these changes
Feb 16, 2022
| ); | ||
| if scope == "Namespaced" { | ||
| println!(r#"#[kube(namespaced)]"#); | ||
| } | ||
|
|
||
| if let Some(CustomResourceSubresources { status: Some(_), .. }) = version.subresources |
|
thanks a lot - tests are passing :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the status data won't be accessible through the generated struct
fixes #4
Signed-off-by: Flavio Percoco [email protected]