-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add astefanutti as member of Kubeflow org #742
Conversation
Hi @astefanutti. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
df2e3b7
to
49c754a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for awesome contributions!
+1
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these contributions @astefanutti 🎉
/lgtm
@james-jwu @zijianjoy Do you know if our pre-commits are broken ?
@kubeflow/wg-pipeline-leads @chensun do you know how we can debug why kubeflow-internal-acls-github-org job failing? |
I noticed that Prow dashboard doesn't have Spyglass url: |
/ok-to-test |
@astefanutti Could you rebase this PR as Andrey fixed repository issue. |
I am not sure if that was fixed since @cjwagner and @simony-gke is still working to update kubeconfig: GoogleCloudPlatform/oss-test-infra#2430 (comment) |
/retest |
Signed-off-by: Antonin Stefanutti <[email protected]>
49c754a
to
163b1b2
Compare
I've just rebased it 👍🏼. |
Oh, I see... |
/retest |
1 similar comment
/retest |
It looks that CI is working now 🎉 |
/lgtm |
Membership Request
Please provide links to PRs or other contributions (2-3):
kubeflow/trainer#2330
kubeflow/trainer#2332
kubeflow/trainer#2387
Please list 2 existing members who are sponsoring your membership:
@andreyvelich
@tenzen-y
Output of
pytest test_org_yaml.py
: