Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add astefanutti as member of Kubeflow org #742

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

astefanutti
Copy link
Contributor

Membership Request

Please provide links to PRs or other contributions (2-3):

kubeflow/trainer#2330
kubeflow/trainer#2332
kubeflow/trainer#2387

Please list 2 existing members who are sponsoring your membership:

@andreyvelich
@tenzen-y

Output of pytest test_org_yaml.py:

$ pytest test_org_yaml.py
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.11.9, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/antonin/Development/kubeflow/internal-acls/github-orgs
plugins: anyio-4.8.0
collected 1 item                                                                                                                                             

test_org_yaml.py .                                                                                                                                     [100%]

===================================================================== 1 passed in 0.07s ======================================================================

Copy link

Hi @astefanutti. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@astefanutti
Copy link
Contributor Author

/cc @andreyvelich @tenzen-y

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for awesome contributions!

+1

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these contributions @astefanutti 🎉
/lgtm
@james-jwu @zijianjoy Do you know if our pre-commits are broken ?

@andreyvelich
Copy link
Member

@kubeflow/wg-pipeline-leads @chensun do you know how we can debug why kubeflow-internal-acls-github-org job failing?

@andreyvelich
Copy link
Member

I noticed that Prow dashboard doesn't have Spyglass url:
https://oss.gprow.dev/?repo=kubeflow%2Finternal-acls

@tenzen-y
Copy link
Member

/ok-to-test
/retest

@tenzen-y
Copy link
Member

@astefanutti Could you rebase this PR as Andrey fixed repository issue.

@andreyvelich
Copy link
Member

andreyvelich commented Feb 13, 2025

I am not sure if that was fixed since @cjwagner and @simony-gke is still working to update kubeconfig: GoogleCloudPlatform/oss-test-infra#2430 (comment)

@andreyvelich
Copy link
Member

/retest

@astefanutti
Copy link
Contributor Author

@astefanutti Could you rebase this PR as Andrey fixed repository issue.

I've just rebased it 👍🏼.

@tenzen-y
Copy link
Member

I am not sure if that was fixed since @cjwagner and @simony-gke is still working to update kubeconfig: GoogleCloudPlatform/oss-test-infra#2430 (comment)

Oh, I see...

@andreyvelich
Copy link
Member

/retest

1 similar comment
@andreyvelich
Copy link
Member

/retest

@andreyvelich
Copy link
Member

It looks that CI is working now 🎉
Thank you for your help @simony-gke @cjwagner

@andreyvelich
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 13, 2025
@google-oss-prow google-oss-prow bot merged commit 539ab4b into kubeflow:master Feb 13, 2025
3 checks passed
@astefanutti astefanutti deleted the pr-astefanutti branch February 14, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants