Fixing build broken links for netlify build (remove from todoPatterns)

[jaiakash]

Hi, I removed all (for now yes, all) links from todoPatterns to check the status of netlify build.

Update 1: When i removed all the links total 6 tests were failing.

After reverting those link patterns, build is passing.

Fixes #3960

[google-oss-prow]

Hi @jaiakash. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Arhell]

/ok-to-test

[hbelmiro]

@jaiakash Have you verified where the pending links are? Please consider using skipPatterns as mentioned by Mathew in the issue.

NOTE: if some of the TODO links are actually correct but the plugin is making a mistake, we can use the skipPatterns section instead, so they don't appear in the logs.

[jaiakash]

Hi @hbelmiro, So I tried to dig deeper into the issue. There are 4 patterns that are causing issues right now. I will go through one by one.

1. public/docs/started/getting-started
   This is the legacy page for getting started/installation for KubeFlow. Currently, 2 places ( first is here and 2nd is here ) we are using this link.

Solution: We can replace it with KubeFlow installation link.

2. public/docs/distributions/gke/
   I think these pages are permanently moved or deleted for the current version of docs. There is no occurrence of this pattern in new docs as relative path, only legacy-v1 has these links as relative path. New docs uses absolute path for GKE. Check below line
   

   website/content/en/docs/components/pipelines/concepts/pipeline-root.md

   Line 30 in f82061c

   check [authentication-pipelines](https://www.kubeflow.org/docs/distributions/gke/pipelines/authentication-pipelines/)

Solution: We have to use GKE docs absolute link for referencing above pattern. GKE Docs

[jaiakash]

3. public/docs/other-guides
   I did not understand what this other guide meant in docs. The link itself is broken on the production webssite. Click on Further setup and troubleshooting on this page https://www.kubeflow.org/docs/started/support/#support-from-the-kubeflow-community
   Let me know what this link is supposed to do.

4. public/docs/examples/shared-resources
   This pattern exists only in legacy-v1 docs only. I think this link to supposed to redirect to the examples page.

Solution: Replace this link with examples page (https://www.kubeflow.org/docs/started/kubeflow-examples/)

[jaiakash]

Hi @hbelmiro @thesuperzapper, can you please review and give your suggestions?

[hbelmiro]

@jaiakash for [3], I suggest removing that bullet.
All the other solutions proposed sound good to me.

[jaiakash]

Hi @hbelmiro ,

1. public/docs/started/getting-started
   This is the legacy page for getting started/installation for KubeFlow. Currently, 2 places ( first is here and 2nd is here ) we are using this link.

Solution: We can replace it with KubeFlow installation link.

2. public/docs/distributions/gke/
   I think these pages are permanently moved or deleted for the current version of docs. There is no occurrence of this pattern in new docs as relative path, only legacy-v1 has these links as relative path. New docs uses absolute path for GKE.
   Solution: We have to use GKE docs absolute link for referencing above pattern. GKE Docs

For 1, I changed the link to KubeFlow installation docs.
For 2, I tried using Kubeflow link and then redirecting to GKE docs, but still the tests were failing. So I changed to actual GKE docs links.

3. public/docs/other-guides
   I did not understand what this other guide meant in docs. The link itself is broken on the production webssite. Click on Further setup and troubleshooting on this page kubeflow.org/docs/started/support#support-from-the-kubeflow-community
   Let me know what this link is supposed to do.
4. public/docs/examples/shared-resources
   This pattern exists only in legacy-v1 docs only. I think this link to supposed to redirect to the examples page.

Solution: Replace this link with examples page (kubeflow.org/docs/started/kubeflow-examples)

For 3, I deleted it since its not needed now.

For 4, shared resources are supposed to point at examples but not for all the pages, so I moved it to skipPatterns

[hbelmiro]

/lgtm

[jaiakash]

Any update on PR @hbelmiro ?

[hbelmiro]

@andreyvelich @terrytangyuan can one of you guys PTAL?

[terrytangyuan]

Thanks!

/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment