-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 setup Trivy scanning for supported release branches #7874
🌱 setup Trivy scanning for supported release branches #7874
Conversation
@ykakarap The jobs on the release branches are currently not doing anything, right? I would probably just keep them there. Otherwise would the idea be that as soon as we branch away a release branch in the future we would have to delete the scan.yaml? (we can still clean them up now if we want as they never worked, but if not necessary I would prefer to not making this a pattern going forward) |
Thx for taking care of this, just a few nits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
(pending nits)
LGTM label has been added. Git tree hash: 8638434b09bedcca25b7cadaaeec26456f1c83f8
|
c93d489
to
a21cd00
Compare
Yes.
Sounds good. Let's just keep them. |
/lgtm |
LGTM label has been added. Git tree hash: cfdf8e4c01ed2c6565a3591cdff2866efeccc776
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ykakarap for tacking care of this, really appreciated!
/lgtm
/approve
a21cd00
to
7fdc285
Compare
Rebased to resolve merge conflicts. |
/lgtm |
LGTM label has been added. Git tree hash: 1204be7539dba4f86c895e9a3d365a3010cf207b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Update: Yesterdays scan ran on all three supported branches. The changes is working as desired. https://github.com/kubernetes-sigs/cluster-api/actions/runs/3930140568 |
What this PR does / why we need it:
This PR adds Trivy scanning job to all supported release branches.
By default
on: schedule
jobs only run on the default branch. Copying this workflow to release branches does not trigger the job on the release branches.Additional notes:
With this we can drop the scan.yaml files from the release branches to avoid confusion as they currently do not do anything.
scan.yaml
was added in in the following PRs:Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #