Merge pull request #1215 from Abirdcfly/master

fix: descheduler_loop_duration_seconds has wrong value
kubernetes-sigs · Aug 10, 2023 · f4c64c2 · f4c64c2
2 parents 3170404 + ca57818
commit f4c64c2
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/pkg/descheduler/descheduler.go b/pkg/descheduler/descheduler.go
@@ -112,8 +112,9 @@ func (d *descheduler) runDeschedulerLoop(ctx context.Context, nodes []*v1.Node)
 	var span trace.Span
 	ctx, span = tracing.Tracer().Start(ctx, "runDeschedulerLoop")
 	defer span.End()
-	loopStartDuration := time.Now()
-	defer metrics.DeschedulerLoopDuration.With(map[string]string{}).Observe(time.Since(loopStartDuration).Seconds())
+	defer func(loopStartDuration time.Time) {
+		metrics.DeschedulerLoopDuration.With(map[string]string{}).Observe(time.Since(loopStartDuration).Seconds())
+	}(time.Now())
 
 	// if len is still <= 1 error out
 	if len(nodes) <= 1 {