Remove elevated permissions from metrics-server

[shuaich]

Description

A non-privileged port 10250 is used as targetPort, which enables the
removal of capability cap_net_bind_service, please refer to
kubernetes/kubernetes#105957

Testing

• Manual Testing
  Create a k8s cluster using kubetest2 with gce as provider and deploy metrics-server with the update image. Manually query metrics.k8s.io API.

kubectl get --raw /apis/metrics.k8s.io/v1beta1/nodes
kubectl get --raw /apis/metrics.k8s.io/v1beta1/nodes/${worker_node}
kubectl get --raw /apis/metrics.k8s.io/v1beta1/pods
kubectl get --raw /apis/metrics.k8s.io/v1beta1/namespaces/kube-system/pods/${system_pod}
kubectl get --raw /apis/metrics.k8s.io/v1beta1/namespaces/default/pods/${user_pod}

• Unit Testing & e2e Testing

make test-unit
make test-version
make test-e2e

What this PR does / why we need it:
This PR rolls back capability cap_net_bind_service.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No

[k8s-ci-robot]

Welcome @shuaich!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @shuaich. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shuaich]

/cc @serathius

[serathius]

Can you also update port number to non privileged in https://github.com/kubernetes-sigs/metrics-server/blob/master/manifests/base/deployment.yaml#L35

[shuaich]

Updated the secure-port and containerPort to use 10250.

[serathius]

/ok-to-test

[serathius]

Please update port in https://github.com/kubernetes-sigs/metrics-server/blob/master/test/e2e_test.go#L228

Removing cap also means we can remove buildx in https://github.com/kubernetes-sigs/metrics-server/blob/master/Makefile#L48
The docker pull is also not needed.

For this MS distribution we might want to other port number than Kubelet port. Could you change it to 4443, which is more natural.

[serathius]

/lgtm

[serathius]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius, shuaich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shuaich]

/cherrypick release-0.5