Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPA: Enforce Flag Documentation Update in CI #7844

Open
omerap12 opened this issue Feb 18, 2025 · 4 comments
Open

VPA: Enforce Flag Documentation Update in CI #7844

omerap12 opened this issue Feb 18, 2025 · 4 comments
Assignees
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@omerap12
Copy link
Member

Currently, our CI pipeline here checks for various aspects like linting and formatting.

With this PR, we are automatically generating flag documentation for all VPA components. To ensure consistency, we need to verify that whenever a new flag is introduced, the corresponding script is run. If not, the CI should fail the build until the developer commits the updated flag documentation.

To enforce this, we should add a new script called verify-vpa-flags.sh, which will:

  1. Run vertical-pod-autoscaler/hack/generate-flags.sh.
  2. Compare the output with vertical-pod-autoscaler/docs/flags.md.
  3. Fail the CI if any differences are detected.

/good-first-issue
/area vertical-pod-autoscaler
/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@omerap12:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Currently, our CI pipeline here checks for various aspects like linting and formatting.

With this PR, we are automatically generating flag documentation for all VPA components. To ensure consistency, we need to verify that whenever a new flag is introduced, the corresponding script is run. If not, the CI should fail the build until the developer commits the updated flag documentation.

To enforce this, we should add a new script called verify-vpa-flags.sh, which will:

  1. Run vertical-pod-autoscaler/hack/generate-flags.sh.
  2. Compare the output with vertical-pod-autoscaler/docs/flags.md.
  3. Fail the CI if any differences are detected.

/good-first-issue
/area vertical-pod-autoscaler
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 18, 2025
@omerap12
Copy link
Member Author

cc @adrianmoisey @voelzmo

@pjsharath28
Copy link

/assign

@Shubham82
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants