[occm] LB tests failures are masked

[dulek]

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
In test-lb-service.sh we do trap "delete_resources" EXIT to make sure we cleanup resources on a test failure. In there, we only fetched the $? after making a check for ${AUTO_CLEAN_UP}, which itself alters the code to 0, so function always returns success. This means tests can never really fail.

What you expected to happen:
Tests can fail.

How to reproduce it:
Run the tests.

Anything else we need to know?:
It's already fixed, I'm creating bugs historically.

Environment:

• openstack-cloud-controller-manager(or other related binary) version:
• OpenStack version:
• Others:

[dulek]

Done in #2540