Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : getStringFromServiceAnnotation() #2392

Merged
merged 1 commit into from
Oct 17, 2023
Merged

test : getStringFromServiceAnnotation() #2392

merged 1 commit into from
Oct 17, 2023

Conversation

yorubad-dev
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes(if applicable):
fixes #

Special notes for reviewers:

Release note:

NONE

cover all possible edge cases that can during the use of this function and test for behavour of function giving hardcoded value incase there is a change in the logic of the function

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @KingDaemonX. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 5, 2023
@yorubad-dev yorubad-dev force-pushed the test-getStringFromServiceAnnotation branch from 25c7b5a to 35f6ea7 Compare October 6, 2023 07:20
@dulek
Copy link
Contributor

dulek commented Oct 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2023
dulek
dulek requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please just address the comment about usage of asserts.

pkg/openstack/loadbalancer_test.go Outdated
Comment on lines 682 to 684
if got := getStringFromServiceAnnotation(test.testArgs.service, test.testArgs.annotationKey, test.testArgs.defaultSetting); got != test.expect {
t.Errorf("[Error] : getStringFromServiceAnnotation() => %s, expecting = %s", got, test.expect)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done through assert.Equal().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted! and fixed

@yorubad-dev yorubad-dev force-pushed the test-getStringFromServiceAnnotation branch from 35f6ea7 to 5bdcf6c Compare October 6, 2023 20:15
dulek
dulek requested changes Oct 9, 2023
View reviewed changes
pkg/openstack/loadbalancer_test.go Outdated
Comment on lines 591 to 605
{
name: "enter valid arguments with annotations",
testArgs: testArgs{
service: &corev1.Service{
ObjectMeta: v1.ObjectMeta{
Namespace: "service-namespace",
Name: "service-name",
Annotations: map[string]string{"annotationKey": "annotation-Value"},
},
},
annotationKey: "annotationKey",
defaultSetting: "default-setting",
},
expected: "annotation-Value",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a duplicate of the case number 2 - with the same name.

Copy link
Contributor Author

@yorubad-dev yorubad-dev Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, my bad, i used that line to create a populated field before editing the unit test and missed it
thank you catching it :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023
@yorubad-dev yorubad-dev force-pushed the test-getStringFromServiceAnnotation branch 3 times, most recently from 1d294c2 to ec964ed Compare October 12, 2023 08:51
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023
@dulek
Copy link
Contributor

dulek commented Oct 12, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2023
@yorubad-dev yorubad-dev force-pushed the test-getStringFromServiceAnnotation branch from ec964ed to 1aef487 Compare October 15, 2023 16:57
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2023
pierreprinetti
pierreprinetti approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@pierreprinetti pierreprinetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please rebase and we're good to merge.

@pierreprinetti
Copy link
Member

My bad, this is rebased already. Let's go!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4900dd0 into kubernetes:master Oct 17, 2023
mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 6, 2024
@yorubad-dev @mandre
test : getStringFromServiceAnnotation (kubernetes#2392)
39373b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek requested changes

@pierreprinetti pierreprinetti pierreprinetti approved these changes

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@dulek dulek

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yorubad-dev @k8s-ci-robot @dulek @pierreprinetti