Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test buid monitor create opts #2429

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Test buid monitor create opts #2429

merged 1 commit into from
Oct 30, 2023

Conversation

majorchork
Copy link
Contributor

What this PR does / why we need it:
this pr adds unit test for buildMonitorCreateOpts LbaasV2 method in loadbalancer.go
Which issue this PR fixes(if applicable):
refers #2400

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 13, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @majorchork. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2023
@dulek
Copy link
Contributor

dulek commented Oct 13, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2023
dulek
dulek requested changes Oct 13, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023
@majorchork majorchork force-pushed the test-buidMonitorCreateOpts branch 2 times, most recently from 4ff271e to a3623d6 Compare October 19, 2023 00:37
@majorchork
Copy link
Contributor Author

hello @pierreprinetti, kindly take a look at this test and please let me know if you have any suggestions 😃

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2023
pierreprinetti
pierreprinetti suggested changes Oct 19, 2023
View reviewed changes
@majorchork majorchork force-pushed the test-buidMonitorCreateOpts branch from a3623d6 to bb0347f Compare October 19, 2023 10:04
@majorchork majorchork marked this pull request as draft October 19, 2023 10:14
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 19, 2023
@majorchork majorchork force-pushed the test-buidMonitorCreateOpts branch from bb0347f to b1163dd Compare October 20, 2023 07:48
@majorchork majorchork marked this pull request as ready for review October 20, 2023 07:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2023
@pierreprinetti
Copy link
Member

Thanks. Please squash and we should be ready to merge!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2023
@majorchork majorchork force-pushed the test-buidMonitorCreateOpts branch from b1163dd to d89b9ac Compare October 21, 2023 13:01
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2023
@majorchork
Copy link
Contributor Author

Thanks. Please squash and we should be ready to merge!

thanks a lot, squashed!😅

@majorchork
Copy link
Contributor Author

/retest

@dulek
Copy link
Contributor

dulek commented Oct 24, 2023

Seems like this is missing a case when healthCheckNodePort=0?

@majorchork
test: LbaasV2 method buildMonitorCreateOpts
45ef1be 
	test: LbaasV2 method buildMonitorCreateOpts
@majorchork majorchork force-pushed the test-buidMonitorCreateOpts branch from d89b9ac to 45ef1be Compare October 29, 2023 00:45
@majorchork majorchork requested a review from dulek October 29, 2023 01:04
@majorchork
Copy link
Contributor Author

Seems like this is missing a case when healthCheckNodePort=0?

Wow! thanks a lot. Nice catch! I've added it now

@dulek
Copy link
Contributor

dulek commented Oct 30, 2023

/lgtm

@dulek
Copy link
Contributor

dulek commented Oct 30, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit b1d415f into kubernetes:master Oct 30, 2023
mandre pushed a commit to shiftstack/cloud-provider-openstack that referenced this pull request Feb 6, 2024
@majorchork @mandre
test: LbaasV2 method buildMonitorCreateOpts (kubernetes#2429)
c080143 
test: LbaasV2 method buildMonitorCreateOpts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

@pierreprinetti pierreprinetti Awaiting requested review from pierreprinetti

@dulek dulek Awaiting requested review from dulek

Assignees

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@majorchork @k8s-ci-robot @dulek @pierreprinetti