[octavia-ingress-controller] Update listener timeouts #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure that listener timeouts are updated when their values are changed on the Ingress resource annotations.
k8s-ci-robot
added
release-note-none
|
This extends #2435 a bit. |
k8s-ci-robot
added
the
size/XS
|
@pierreprinetti and @jichenjc, you might want to take a look. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
MaysaMacedo
reviewed
Nov 10, 2023
| @@ -367,7 +367,11 @@ func (os *OpenStack) EnsureListener(name string, lbID string, secretRefs []strin | |||
| } else { | |||
| if len(listenerAllowedCIDRs) > 0 && !reflect.DeepEqual(listener.AllowedCIDRs, listenerAllowedCIDRs) { | |||
| _, err := listeners.Update(os.Octavia, listener.ID, listeners.UpdateOpts{ | |||
| AllowedCIDRs: &listenerAllowedCIDRs, | |||
| AllowedCIDRs: &listenerAllowedCIDRs, | |||
There was a problem hiding this comment.
Shouldn't the timeouts be updated when there is a change in the timeouts and not when allowedCIDRs has changed?
There was a problem hiding this comment.
@MaysaMacedo: Whoops, I missed this, obviously valid comment. It's fixed in #2518.
k8s-ci-robot
added
the
lgtm
dulek
added a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Jan 9, 2024
PR kubernetes#2468 used an incorrect condition when updating the listener timeout values and only updates them when listener's allowedCIDRs are updated. This commit fixes this by making sure timeout values are checked too.
dulek
added a commit
to shiftstack/cloud-provider-openstack
that referenced
this pull request
Jan 9, 2024
PR kubernetes#2468 used an incorrect condition when updating the listener timeout values and only updates them when listener's allowedCIDRs are updated. This commit fixes this by making sure timeout values are checked too.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jan 31, 2024
PR #2468 used an incorrect condition when updating the listener timeout values and only updates them when listener's allowedCIDRs are updated. This commit fixes this by making sure timeout values are checked too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit makes sure that listener timeouts are updated when their values are changed on the Ingress resource annotations.
cc @sakshi-1505
Which issue this PR fixes(if applicable):
fixes #2243
Special notes for reviewers:
Release note: