-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] LoadBalancer ProxyProtocol v2 feature #2635
[occm] LoadBalancer ProxyProtocol v2 feature #2635
Conversation
Hi @Lucasgranet. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3316906
to
8eeacf5
Compare
6e2b777
to
a77cf79
Compare
/ok-to-test |
a77cf79
to
5ab65dd
Compare
@zetaab I'm not sure but E2E's failures seem not related to my PR. Can you have a look please? |
/test openstack-cloud-controller-manager-e2e-test |
@Lucasgranet can you rebase this pr against master? Master contain fixes for the e2e tests |
5ab65dd
to
f0634c9
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thank you @Lucasgranet
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
from this comment I think default is still v1, correct ? |
docs/openstack-cloud-controller-manager/expose-applications-using-loadbalancer-type-service.md
Show resolved
Hide resolved
/lgtm |
f0634c9
to
44f97c5
Compare
/lgtm |
What this PR does / why we need it:
The PR brings the ability of choosing the ProxProtocol in version 2 (instead of v1).
Two new values are supported for
loadbalancer.openstack.org/proxy-protocol
Which issue this PR fixes(if applicable):
fixes #2585
Special notes for reviewers:
N/A
Release note: