Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[occm] LoadBalancer ProxyProtocol v2 feature #2635

Merged

Conversation

Lucasgranet
Copy link
Contributor

What this PR does / why we need it:
The PR brings the ability of choosing the ProxProtocol in version 2 (instead of v1).

Two new values are supported for loadbalancer.openstack.org/proxy-protocol

loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "false" # Default value, no proxy protocol enable 
loadbalancer.openstack.org/proxy-protocol: "v1" # NEW - Enable ProxyProtocolv1
loadbalancer.openstack.org/proxy-protocol: "v2" # NEW - Enable ProxyProtocolv2

Which issue this PR fixes(if applicable):
fixes #2585

Special notes for reviewers:
N/A

Release note:

[openstack-cloud-controller-manager] Support LoadBalancer ProxyProtocol v2 feature

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Lucasgranet. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/lb-proxy-protocol-v2 branch from 3316906 to 8eeacf5 Compare August 27, 2024 09:18
@Lucasgranet Lucasgranet marked this pull request as ready for review August 27, 2024 14:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jichenjc August 27, 2024 14:15
@Lucasgranet Lucasgranet force-pushed the feat/occm/lb-proxy-protocol-v2 branch 2 times, most recently from 6e2b777 to a77cf79 Compare August 29, 2024 12:23
@zetaab
Copy link
Member

zetaab commented Sep 2, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/lb-proxy-protocol-v2 branch from a77cf79 to 5ab65dd Compare September 2, 2024 07:59
@Lucasgranet
Copy link
Contributor Author

@zetaab I'm not sure but E2E's failures seem not related to my PR.

Can you have a look please?

@zetaab
Copy link
Member

zetaab commented Sep 2, 2024

/test openstack-cloud-controller-manager-e2e-test
/test openstack-cloud-controller-manager-ovn-e2e-test

@zetaab
Copy link
Member

zetaab commented Sep 2, 2024

@Lucasgranet can you rebase this pr against master? Master contain fixes for the e2e tests

@Lucasgranet Lucasgranet force-pushed the feat/occm/lb-proxy-protocol-v2 branch from 5ab65dd to f0634c9 Compare September 2, 2024 11:59
@Lucasgranet
Copy link
Contributor Author

/retest

Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thank you @Lucasgranet

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@jichenjc
Copy link
Contributor

jichenjc commented Sep 3, 2024

loadbalancer.openstack.org/proxy-protocol: "true" # Enable ProxyProtocolv1

from this comment I think default is still v1, correct ?

@jichenjc
Copy link
Contributor

jichenjc commented Sep 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@Lucasgranet Lucasgranet force-pushed the feat/occm/lb-proxy-protocol-v2 branch from f0634c9 to 44f97c5 Compare September 3, 2024 08:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@zetaab
Copy link
Member

zetaab commented Sep 3, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit bcd8033 into kubernetes:master Sep 3, 2024
6 checks passed
@Lucasgranet Lucasgranet deleted the feat/occm/lb-proxy-protocol-v2 branch September 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[occm] LoadBalancer ProxyProtocol v2 feature
4 participants