Skip to content

Commit

Permalink
Fix tests after deps update
Browse files Browse the repository at this point in the history
  • Loading branch information
bryk committed Mar 22, 2016
1 parent 493ed42 commit 2bfe1d4
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 9 deletions.
5 changes: 2 additions & 3 deletions src/app/frontend/deploy/deploy.html
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,11 @@ <h3 class="md-headline kd-deploy-form-title">Deploy a Containerized App</h3>
</deploy-from-file>
</div>

<md-button class="md-raised md-primary kd-deploy-btn" type="submit"
<md-button class="md-raised md-primary kd-deploy-submit-button" type="submit"
ng-disabled="ctrl.isDeployDisabled()">
Deploy
</md-button>
<md-button class="md-raised" ng-click="ctrl.cancel()">Cancel</md-button>

<md-button class="md-raised kd-deploy-cancel-button" ng-click="ctrl.cancel()">Cancel</md-button>
</form>
</md-whiteframe>
</div>
2 changes: 1 addition & 1 deletion src/test/integration/deploy/deploy_po.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

export default class DeployPageObject {
constructor() {
this.deployButtonQuery = by.css('.kd-deploy-btn');
this.deployButtonQuery = by.css('.kd-deploy-submit-button');
this.deployButton = element(this.deployButtonQuery);

this.appNameFieldQuery = by.model('ctrl.name');
Expand Down
4 changes: 2 additions & 2 deletions src/test/integration/deploy/deployfromfile_po.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ export default class DeployFromFilePageObject {
this.deployFromFileRadioButtonQuery = by.xpath('//md-radio-button[@value="File"]');
this.deployFromFileRadioButton = element(this.deployFromFileRadioButtonQuery);

this.deployButtonQuery = by.xpath('//button[@type="submit"]');
this.deployButtonQuery = by.css('.kd-deploy-submit-button');
this.deployButton = element(this.deployButtonQuery);

this.cancelButtonQuery = by.xpath('//button[@ng-click="ctrl.cancel()"]');
this.cancelButtonQuery = by.css('.kd-deploy-cancel-button');
this.cancelButton = element(this.cancelButtonQuery);

this.inputContainerQuery = by.tagName('md-input-container');
Expand Down
2 changes: 1 addition & 1 deletion src/test/integration/deploy/deployfromfile_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ describe('Deploy from file view', () => {
page.cancelButton.click();

// then
expect(zeroState.deployButton.isPresent()).toBeTruthy();
expect(zeroState.deployButton.isPresent()).toBe(true);
});

});
3 changes: 1 addition & 2 deletions src/test/integration/stories/deploy_not_existing_img_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ import ZeroStatePageObject from '../zerostate/zerostate_po';
* - [Logs Page] - Check if pod logs show that pod is in pending state.
* - Clean up and delete created resources
*/
// TODO(#494): Reenable this test when fixed.
xdescribe('Deploy not existing image story', () => {
describe('Deploy not existing image story', () => {
/** @type {!ZeroStatePageObject} */
let zeroStatePage;

Expand Down

0 comments on commit 2bfe1d4

Please sign in to comment.