Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App name field should indicate the max lenght #444

Closed
cheld opened this issue Feb 25, 2016 · 3 comments
Closed

App name field should indicate the max lenght #444

cheld opened this issue Feb 25, 2016 · 3 comments

Comments

@cheld
Copy link
Contributor

cheld commented Feb 25, 2016

Issue details

Some field in Dashboard indicate the number of chars that can be entered like 0/63. Some fields don't.

Steps to reproduce
  1. Open deploy from settings
  2. click in app name
Observed result

nothing

Expected result

max length indicator is shown below input field

Comments

same for some other fields
@cheld
Copy link
Contributor Author

cheld commented Feb 25, 2016

This is also material design default

@cheld
Copy link
Contributor Author

cheld commented Feb 26, 2016

P1

@bryk
Copy link
Contributor

bryk commented Mar 1, 2016

This is all about using md-maxlengh instead of ng-maxlength. I'll take this.

@bryk bryk added this to the v1.0 milestone Mar 1, 2016
bryk added a commit to bryk/dashboard that referenced this issue Mar 1, 2016
@bryk
Unify maxlength validation through the app
4fdfb3e 
This unifies error messages and makes use of md-maxlength for validation
(eg., to show 0/24 length counter).

Fixes kubernetes#444
@bryk bryk mentioned this issue Mar 1, 2016
Merged
bryk added a commit to bryk/dashboard that referenced this issue Mar 1, 2016
@bryk
Unify maxlength validation through the app
d64b6e5 
This unifies error messages and makes use of md-maxlength for validation
(eg., to show 0/24 length counter).

Fixes kubernetes#444
@bryk bryk closed this as completed in #469 Mar 1, 2016
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this issue Sep 27, 2021
@skdwriting
Merge pull request kubernetes#444 from kumarashit/aks_dev
9771bde 
Adding CHANGELOG for v1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryk @cheld