Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App name validation message overlaps character counter #477

Closed
digitalfishpond opened this issue Mar 2, 2016 · 5 comments
Closed

App name validation message overlaps character counter #477

digitalfishpond opened this issue Mar 2, 2016 · 5 comments

Comments

@digitalfishpond
Copy link
Contributor

Validation message for wrong pattern on Deploy --> Specify app details below --> App name overlaps the character counter

validationoverlap

Steps to reproduce
  • Deploy
  • select "Specify app details below"
  • In App name field, type a string with illegal characters (capitals, underscores, etc)
  • focus out
Observed result

Message overlaps character counter

Expected result

Character counter should be separate from message

@bryk
Copy link
Contributor

bryk commented Mar 2, 2016

Hmm... Isnt this an angular material bug? The demo on material site works as expected: https://material.angularjs.org/latest/demo/input

@bryk bryk added this to the v1.0 milestone Mar 2, 2016
@floreks
Copy link
Member

floreks commented Mar 2, 2016

This is our bug because ng-messages are surrounded with div: https://github.com/kubernetes/dashboard/blob/master/src/app/frontend/deploy/deployfromsettings.html#L26

Height is changed and that's why text is overlapping counter. Deleting div fixes problem.

@digitalfishpond
Copy link
Contributor Author

Ah. deleting div also causes jittering on a number of events... I wonder if it would be possible to assign a flex value (like '80') to the div? or put a div around the counter too?

@bryk
Copy link
Contributor

bryk commented Mar 3, 2016

deleting div also causes jittering on a number of events..

Can you explain this?

@digitalfishpond
Copy link
Contributor Author

If I remember correctly, the div was added to avoid the rest of the form jumping up and down (in Firefox at least) upon focus and upon showing error message.

bryk added a commit to bryk/dashboard that referenced this issue Mar 3, 2016
bryk added a commit to bryk/dashboard that referenced this issue Mar 3, 2016
@bryk bryk closed this as completed in #490 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants