Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling issues on serve:prod #546

Closed
floreks opened this issue Mar 18, 2016 · 7 comments · Fixed by #557
Closed

Styling issues on serve:prod #546

floreks opened this issue Mar 18, 2016 · 7 comments · Fixed by #557
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@floreks
Copy link
Member

floreks commented Mar 18, 2016

Issue details

Environment
Dashboard version: HEAD
Kubernetes version: HEAD
Browser: IE, FF, Chrome

On serve prod there are some styling issues. I've removed node_modules and bower_components and did a clean install. Could you check and confirm?

PS. On serve this issue does not exist.

zrzut ekranu z 2016-03-18 11-08-26
zrzut ekranu z 2016-03-18 11-08-36
@floreks floreks mentioned this issue Mar 18, 2016
Merged
@maciaszczykm maciaszczykm added kind/bug Categorizes issue or PR as related to a bug. area/styling labels Mar 18, 2016
@bryk
Copy link
Contributor

bryk commented Mar 18, 2016

Oops, I can reproduce this. It looks like the HTML minifier is broken. It produces bogus output.

@bryk
Copy link
Contributor

bryk commented Mar 18, 2016

How about we make our bower and npm dependencies exact? And update them often?

@floreks
Copy link
Member Author

floreks commented Mar 18, 2016

We should do that. This way we will have better control over external changes that can potentially break something on our side.

@maciaszczykm
Copy link
Member

All of them? Maybe better idea is to do it only for specific dependencies and keep others in current state?

@bryk
Copy link
Contributor

bryk commented Mar 22, 2016

I think this is fixed. I'll take care of dependencies next.

@bryk bryk closed this as completed Mar 22, 2016
@floreks
Copy link
Member Author

floreks commented Mar 22, 2016

It's not. I've prepared a simple fix for that.

@bryk
Copy link
Contributor

bryk commented Mar 22, 2016

Ouch, sorry. My fault.

@bryk bryk reopened this Mar 22, 2016
@floreks floreks mentioned this issue Mar 22, 2016
Merged
@bryk bryk closed this as completed in #557 Mar 22, 2016
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this issue Sep 27, 2021
@NajmudheenCT
Merge pull request kubernetes#546 from anvithks/cherry-pick-isabela-rc2
382c84d 
Cherry pick Bucket management and Lifecycle changes from  isabela-dev to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix serve:prod styling issues floreks/dashboard
3 participants
@bryk @floreks @maciaszczykm