-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing issue 3030 pods owning pods on dashboard #3108
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
Codecov Report
@@ Coverage Diff @@
## master #3108 +/- ##
==========================================
+ Coverage 54.26% 54.49% +0.23%
==========================================
Files 564 564
Lines 12259 12324 +65
==========================================
+ Hits 6652 6716 +64
- Misses 5347 5349 +2
+ Partials 260 259 -1
Continue to review full report at Codecov.
|
/assign @bryk |
/assign @rf232 |
commit f7b2fe40a7ee2ffa15f4af829f5dbe9a0e0a5f01 feels unrelated to the rest of the changes, could you take a look at that? Also i think you might want to do a gofmt on the code, since either the github interface is lying to me, or you are using 2 space indents instead of tabs? |
Sorry @rf232, I had a faulty pulled commit f7b2fe4 from master, my mistake. Just did a quick git rebase, should work now. |
/lgtm /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EdanSneh, rf232 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixing issue 3030 pods owning pods on dashboard (kubernetes#3108)
Fixing Bug 3030: Dashboard recognizes pods owning other pods. Owned-pods have a UI of the owner-pod, which shows all the owner-pod's images and total running pods.