Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue 3030 pods owning pods on dashboard #3108

Merged
merged 4 commits into from
Jul 3, 2018

Conversation

EdanSneh
Copy link
Contributor

Fixing Bug 3030: Dashboard recognizes pods owning other pods. Owned-pods have a UI of the owner-pod, which shows all the owner-pod's images and total running pods.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2018
@EdanSneh EdanSneh closed this Jun 22, 2018
@EdanSneh EdanSneh reopened this Jun 22, 2018
@EdanSneh
Copy link
Contributor Author

/check-cla

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #3108 into master will increase coverage by 0.23%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3108      +/-   ##
==========================================
+ Coverage   54.26%   54.49%   +0.23%     
==========================================
  Files         564      564              
  Lines       12259    12324      +65     
==========================================
+ Hits         6652     6716      +64     
- Misses       5347     5349       +2     
+ Partials      260      259       -1
Impacted Files Coverage Δ
src/app/backend/resource/common/pod.go 80.2% <100%> (+12.96%) ⬆️
src/app/backend/resource/controller/controller.go 20.23% <100%> (+16.12%) ⬆️
src/app/backend/sync/secret.go 66.94% <0%> (-2.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f223aa8...4145b47. Read the comment docs.

@EdanSneh EdanSneh closed this Jun 22, 2018
@EdanSneh EdanSneh reopened this Jun 22, 2018
@EdanSneh
Copy link
Contributor Author

/assign @bryk

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2018
@konryd
Copy link

konryd commented Jul 2, 2018

/assign @rf232

@rf232
Copy link
Contributor

rf232 commented Jul 2, 2018

commit f7b2fe40a7ee2ffa15f4af829f5dbe9a0e0a5f01 feels unrelated to the rest of the changes, could you take a look at that?

Also i think you might want to do a gofmt on the code, since either the github interface is lying to me, or you are using 2 space indents instead of tabs?

@EdanSneh
Copy link
Contributor Author

EdanSneh commented Jul 2, 2018

Sorry @rf232, I had a faulty pulled commit f7b2fe4 from master, my mistake. Just did a quick git rebase, should work now.

@rf232
Copy link
Contributor

rf232 commented Jul 3, 2018

/lgtm /approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EdanSneh, rf232

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2018
@rf232 rf232 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit f585597 into kubernetes:master Jul 3, 2018
scott-kawaguchi added a commit to scott-kawaguchi/dashboard that referenced this pull request Jul 3, 2018
fixing issue 3030 pods owning pods on dashboard (kubernetes#3108)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants