-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugin support on the frontend #4094
Conversation
425c773
to
273717a
Compare
Testing it :) |
The plugin works, that's great. Few remarks from my side:
Another thing to consider here might be adding CRD from our backend and listing
At the moment that's it. I really appreciate all the effort and I think most crucial part is already done. Keep it up! |
c1abe24
to
f6b49df
Compare
a41c80e
to
aef227c
Compare
Codecov Report
@@ Coverage Diff @@
## master #4094 +/- ##
==========================================
+ Coverage 46.01% 46.57% +0.56%
==========================================
Files 198 200 +2
Lines 9300 9366 +66
Branches 105 105
==========================================
+ Hits 4279 4362 +83
+ Misses 4760 4735 -25
- Partials 261 269 +8
Continue to review full report at Codecov.
|
05503d9
to
49b9dff
Compare
5f3592f
to
b4ca5b7
Compare
b4ca5b7
to
880c92e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajatprabha, floreks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: #4069