Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'delete service' checkbox default value to true #457

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 29, 2016

Related to #425

Also centers tooltip icon with message after the text.

Review on Reviewable

@maciaszczykm
Copy link
Member

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@floreks floreks force-pushed the delete-rc-checkbox branch 2 times, most recently from d35eb96 to f99c814 Compare February 29, 2016 10:06
@codecov-io
Copy link

Current coverage is 81.76%

Merging #457 into master will not affect coverage as of 0b56a2e

@@            master    #457   diff @@
======================================
  Files           77      77       
  Stmts          625     625       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            511     511       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 0b56a2e

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Feb 29, 2016

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Feb 29, 2016
Changed 'delete service' checkbox default value to true
@bryk bryk merged commit 0d12170 into kubernetes:master Feb 29, 2016
@bryk bryk deleted the delete-rc-checkbox branch February 29, 2016 13:34
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Fixed issues with Huawei FS create form. Fixes kubernetes#453 and kubernetes#454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants