Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deploy from file on IE #478

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

floreks
Copy link
Member

@floreks floreks commented Mar 2, 2016

Fixes #430

According to documentation:
https://developer.mozilla.org/en-US/docs/Web/API/FileReader/readAsBinaryString

reader.readAsBinaryString is deprecated and should not be used. As we are reading text file I've changed it to readAsText. By default it assumes UTF-8 encoding.

Review on Reviewable

@bryk
Copy link
Contributor

bryk commented Mar 2, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@codecov-io
Copy link

Current coverage is 82.29%

Merging #478 into master will not affect coverage as of dd9074e

@@            master    #478   diff @@
======================================
  Files           79      79       
  Stmts          644     644       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            530     530       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of dd9074e

Powered by Codecov. Updated on successful CI builds.

bryk added a commit that referenced this pull request Mar 2, 2016
@bryk bryk merged commit d9c17d1 into kubernetes:master Mar 2, 2016
@bryk bryk deleted the deploy-from-file-ie-fix branch March 2, 2016 13:01
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Added support to register Hitachi VSP and IBM Storwize/SVC storage devices from dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants