Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how users can change apiserver-host in canary deployment #489

Merged
merged 1 commit into from
Mar 4, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 3, 2016

Fixes #484

Review on Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 3, 2016

@taimir @batikanu Can you review?

@codecov-io
Copy link

Current coverage is 82.72%

Merging #489 into master will not affect coverage as of 3062ca9

@@            master    #489   diff @@
======================================
  Files           83      83       
  Stmts          660     660       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            546     546       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 3062ca9

Powered by Codecov. Updated on successful CI builds.

@batikanu
Copy link
Contributor

batikanu commented Mar 4, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


src/deploy/kubernetes-dashboard-canary.yaml, line 34 [r1] (raw file):
here is the first minus extra or it is ok like that?


Comments from the review on Reviewable.io

@batikanu
Copy link
Contributor

batikanu commented Mar 4, 2016

Just one question. Otherwise LGTM.


Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


Comments from the review on Reviewable.io

@bryk
Copy link
Contributor Author

bryk commented Mar 4, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


src/deploy/kubernetes-dashboard-canary.yaml, line 34 [r1] (raw file):
This is YAML. The dash is to indicate a list.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Mar 4, 2016
Clarify how users can change apiserver-host in canary deployment
@bryk bryk merged commit 24f0b5b into kubernetes:master Mar 4, 2016
@bryk bryk deleted the apiserver-host-help branch March 4, 2016 13:49
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
Fixed object restore issue. Added appropriate messages while archiving object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants