Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go report card and gofmt files #500

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Add go report card and gofmt files #500

merged 1 commit into from
Mar 8, 2016

Conversation

maciaszczykm
Copy link
Member

Added Go Report Card badge to README.md with following link: https://goreportcard.com/report/github.com/kubernetes/dashboard

Used gofmt on unformatted files. Fixed few golint issues.

Kubernetes core also uses Go Report Card.

Review on Reviewable

@codecov-io
Copy link

Current coverage is 83.62%

Merging #500 into master will not affect coverage as of 1413951

@@            master    #500   diff @@
======================================
  Files           84      84       
  Stmts          696     696       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            582     582       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 1413951

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Mar 8, 2016

Nice! Thanks. LGTM :)

bryk added a commit that referenced this pull request Mar 8, 2016
Add go report card and gofmt files
@bryk bryk merged commit 36ecc33 into kubernetes:master Mar 8, 2016
@bryk bryk deleted the go-report-card branch March 8, 2016 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants