Fixed test flakiness on application deploy in IE

[floreks]

Fixes #494

I've changed some button queries to use xpath and moved expect block to be executed after click promise is resolved.

[bryk]

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

---

src/test/integration/deploy/deploy_po.js, line 17 [r1] (raw file):
Protractor style guide says to never use xpaths to locate elements: https://github.com/angular/protractor/blob/master/docs/style-guide.md

Can you maybe use class/model/binding?

---

Comments from the review on Reviewable.io

[floreks]

Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion.

---

src/test/integration/deploy/deploy_po.js, line 17 [r1] (raw file):
I've had a good feeling that we shouldn't use xpaths ;) Sure I'll change that. In other PR I'll refactor rest xpaths.

---

Comments from the review on Reviewable.io

[codecov-io]

Current coverage is 85.99%

Merging #508 into master will increase coverage by +2.40% as of 9eee1b0

@@            master    #508   diff @@
======================================
  Files           84      95    +11
  Stmts          695     814   +119
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            581     700   +119
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 9eee1b0

Powered by Codecov. Updated on successful CI builds.

[floreks]

PTAL

[maciaszczykm]

---

Reviewed 2 of 4 files at r1, 2 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[floreks]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

src/test/integration/deploy/deploy_po.js, line 17 [r1] (raw file):
Done.

---

Comments from the review on Reviewable.io

[maciaszczykm]

Reviewed 1 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from the review on Reviewable.io

[bryk]

Can you convert the ID to a class? It is a good practise to never use IDs, unless you really really need them :) With that practise in mind you'll avoid problems when someone adds second deploy button here (which has pretty generic meaning/name, yea?)

Sorry for nagging.