Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml files for testing purposes #553

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Conversation

cheld
Copy link
Contributor

@cheld cheld commented Mar 21, 2016

During last testing round I noticed (from screenshots) that many did testing with poor test data.

I added two yamls as starting point:

  1. The guestbook example with a few small adoptions to work in our local cluster
  2. A RC with all max values set. (ouch...)

Of course, this is not enough. We should create some more.

@floreks Could you please review?


This change is Reviewable

@codecov-io
Copy link

Current coverage is 86.54%

Merging #553 into master will not affect coverage as of 80ff507

@@            master    #553   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 80ff507

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 29, 2016

These 2 examples are good starting point. :lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bryk
Copy link
Contributor

bryk commented Mar 29, 2016

@floreks Merge this :)

@floreks
Copy link
Member

floreks commented Mar 29, 2016

Sure, I'm constantly forgetting that I can merge :)

@floreks floreks merged commit 084a36f into kubernetes:master Mar 29, 2016
@cheld cheld deleted the examples branch April 14, 2016 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants