Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to system applications on the zerostate page #558

Merged
merged 1 commit into from
Mar 22, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 22, 2016

  • previosuly it was a multiline link -> changed this to text and lint
  • changed wording to not expose our internal implementation details`

selection_054


This change is Reviewable

* previosuly it was a multiline link -> changed this to text and lint
* changed wording to not expose our internal implementation details`
@bryk
Copy link
Contributor Author

bryk commented Mar 22, 2016

@taimir @gertipoppel Can you review this?

@codecov-io
Copy link

Current coverage is 86.54%

Merging #558 into master will not affect coverage as of f15d8b0

@@            master    #558   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of f15d8b0

Powered by Codecov. Updated on successful CI builds.

@taimir
Copy link
Contributor

taimir commented Mar 22, 2016

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


src/app/frontend/replicationcontrollerlist/zerostate/zerostate.html, line 41 [r1] (raw file):
I like this better than the previous text. Let me check how it looks on internet explorer :)


Comments from the review on Reviewable.io

@taimir
Copy link
Contributor

taimir commented Mar 22, 2016

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@taimir
Copy link
Contributor

taimir commented Mar 22, 2016

LGTM

bryk added a commit that referenced this pull request Mar 22, 2016
Update link to system applications on the zerostate page
@bryk bryk merged commit f44ef69 into kubernetes:master Mar 22, 2016
@bryk bryk deleted the kube-system branch March 22, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants