Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font and icon build pipeline #560

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 22, 2016

Previously it did't work on my machine. Now it does.

@floreks Can you take a look?


This change is Reviewable

Previously it did't work on my machine. Now it does.
@codecov-io
Copy link

Current coverage is 86.54%

Merging #560 into master will not affect coverage as of 89610a9

@@            master    #560   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 89610a9

Powered by Codecov. Updated on successful CI builds.

@floreks
Copy link
Member

floreks commented Mar 22, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

bryk added a commit that referenced this pull request Mar 22, 2016
Fix font and icon build pipeline
@bryk bryk merged commit 3139c7f into kubernetes:master Mar 22, 2016
@bryk bryk deleted the fonts-build-fix branch March 22, 2016 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants