Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md - Added password information #580

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Conversation

Zhomart
Copy link
Contributor

@Zhomart Zhomart commented Mar 27, 2016

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Zhomart
Copy link
Contributor Author

Zhomart commented Mar 27, 2016

I signed it!

On Sun, Mar 27, 2016 at 1:30 PM googlebot [email protected] wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#580 (comment)

@googlebot
Copy link

CLAs look good, thanks!

@codecov-io
Copy link

Current coverage is 86.54%

Merging #580 into master will not affect coverage as of c314f7d

@@            master    #580   diff @@
======================================
  Files           97      97       
  Stmts          847     847       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            733     733       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of c314f7d

Powered by Codecov. Updated on successful CI builds.

@bryk
Copy link
Contributor

bryk commented Mar 29, 2016

Thanks for helping us! :)

@bryk
Copy link
Contributor

bryk commented Mar 29, 2016

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

@bryk bryk merged commit 621c916 into kubernetes:master Mar 29, 2016
anvithks added a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
…or profiles without replication enabled. Added more display information to Capacity charts (kubernetes#580)

* Fixed the display issues in profile card. Removed replication label

* Added the capacity unit to the legend

Co-authored-by: Sanil Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants