Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocks for navigation and UX that scales for all K8s resources #585

Merged
merged 1 commit into from
Mar 29, 2016

Conversation

bryk
Copy link
Contributor

@bryk bryk commented Mar 29, 2016

  • this will be used later in a design doc proposal
  • also renamed old mocks folder to tell more than just date

See: #584


This change is Reviewable

@bryk
Copy link
Contributor Author

bryk commented Mar 29, 2016

@olekzabl Can you review?

@codecov-io
Copy link

Current coverage is 86.89%

Merging #585 into master will not affect coverage as of 04bace2

@@            master    #585   diff @@
======================================
  Files          102     102       
  Stmts          870     870       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            756     756       
  Partial          0       0       
  Missed         114     114       

Review entire Coverage Diff as of 04bace2

Powered by Codecov. Updated on successful CI builds.

@olekzabl
Copy link
Contributor

A few issues:

  • navigation.png: "togheder" -> "together"
  • manu-extended.png: "manu" -> "menu" (in the file name)
  • rc-details-page-events.png: tooltips disagree with pic! section
    "Properties of the object" does not exist
  • some inconsistencies between details pages:
    • "Properties in structurized form" in {pod,rc}-details-page-overview.png
      look different (no "State" on the latter)
    • Headers of link sections are named by object types in
      {pod,rc}-d-p-o.png while by roles in details-page-template.png
      (ideally, the header should perhaps combine the role and the target
      object type)

On Tue, Mar 29, 2016 at 12:13 PM, Piotr Bryk [email protected]
wrote:

@olekzabl https://github.com/olekzabl Can you review?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#585 (comment)

@floreks
Copy link
Member

floreks commented Mar 29, 2016

  • rc-details-page-events.png: tooltips disagree with pic! section

Ops, I will fix that.

  • some inconsistencies between details pages:
    • "Properties in structurized form" in {pod,rc}-details-page-overview.png
      look different (no "State" on the latter)

This is just a proposal. Should we actually group properties by some common purpose? Tell me which one you like better and I'll adjust other.

  • Headers of link sections are named by object types in
    {pod,rc}-d-p-o.png while by roles in details-page-template.png
    (ideally, the header should perhaps combine the role and the target
    object type)

I'm not sure I know what you mean. Are you referring to the Pod > <name> section on top near action buttons? Is it wrong? On the template we've got Resource 1 > foo instance which I believe is correct. Could you elaborate?

@floreks
Copy link
Member

floreks commented Mar 29, 2016

Please find updated rc - events mock here

@bryk
Copy link
Contributor Author

bryk commented Mar 29, 2016

Please find update rc - events mock here

Can you post the source?

@floreks
Copy link
Member

floreks commented Mar 29, 2016

Here is the link to balsamiq project

@bryk bryk force-pushed the scale-and-navigation-mocks branch from f8dbc7a to c28d14d Compare March 29, 2016 13:18
@bryk
Copy link
Contributor Author

bryk commented Mar 29, 2016

All addressed. PTAL.

@floreks You can delete the links you've posted.

@bryk bryk force-pushed the scale-and-navigation-mocks branch from c28d14d to 4ccab54 Compare March 29, 2016 13:35
* this will be used later in a design doc proposal
* also renamed old mocks folder to tell more than just date

See: kubernetes#584
@bryk bryk force-pushed the scale-and-navigation-mocks branch from 4ccab54 to c189ac8 Compare March 29, 2016 14:23
@bryk
Copy link
Contributor Author

bryk commented Mar 29, 2016

I'll merge to base design doc on this. Any comments can be addressed in follow up PRs.

@bryk bryk merged commit b7867cd into kubernetes:master Mar 29, 2016
@bryk bryk deleted the scale-and-navigation-mocks branch March 29, 2016 14:26
anvithks pushed a commit to anvithks/k8s-dashboard that referenced this pull request Sep 27, 2021
* dhanshree:soda dashboard ui-changes for sony oda

* dhanshree:soda dashboard-ui for sony-oda

* Update proxy.conf.json

* Update proxy.conf.json

* Update proxy.conf.json

* Updated name for sony

* SONY-ODA logo added

* SONY-ODA logo added

Co-authored-by: Click2cloud-Pallas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants