-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update most http links to https links #6535
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @danBamikiya! |
@danBamikiya Could you fix these? |
This doesn't solve mentioned issue but we can merge it as it brings improvement. Please sign the CLA and bump chart version as @desaintmartin asked. |
7491a71
to
2911148
Compare
3d5ceae
to
2ec5da2
Compare
@atoato88 PTAL |
@maciaszczykm Please can you explain how the mentioned issue can be solved? |
Items to solve I said are solved now. 😄 |
Codecov Report
@@ Coverage Diff @@
## master #6535 +/- ##
=======================================
Coverage 42.53% 42.53%
=======================================
Files 217 217
Lines 10627 10627
Branches 160 160
=======================================
Hits 4520 4520
Misses 5841 5841
Partials 266 266 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danBamikiya, shu-mutou The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposal
This updates most external referencing http links to use https by default for better security practice.
Related Issues
#6435