Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Japanese i18n Team #6625

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

t-inu
Copy link
Member

@t-inu t-inu commented Nov 16, 2021

Updates the followings.

  • I think it is a rule to insert a half-width space not only for English words but also for single alphabets and numbers, so change from "英単語" to "英数字"
  • As for the English letters, there is no rule to make it half-width, so describe it.
  • It is better to describe the full-width and half-width usage rules first, rather than describing whether to insert a space, so change the order.

以下について更新します。

  • 英単語だけでなく、単独のアルファベットや数字の場合も半角スペースを入れるルールだと思うため、「英単語」から「英数字」に変更する。
  • 英字について、半角にする決まりが書かれていないので記載する。
  • スペースを入れるかどうかの記載よりも、先に全角と半角の使用ルールを記載するほうがよいので、順番を入れ替える。

/assign @shu-mutou
/cc @atoato88

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/ja Updates or issues for Japanese translations. labels Nov 16, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #6625 (ffd08c5) into master (15300bd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6625   +/-   ##
=======================================
  Coverage   42.59%   42.59%           
=======================================
  Files         217      217           
  Lines       10650    10650           
  Branches      177      177           
=======================================
  Hits         4536     4536           
  Misses       5813     5813           
  Partials      301      301           

@shu-mutou
Copy link
Contributor

/lgtm
Thanks!!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@shu-mutou shu-mutou merged commit 4a932b3 into kubernetes:master Nov 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shu-mutou, t-inu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Updates or issues for Japanese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants