Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip ANSI codes from logs #6801

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Strip ANSI codes from logs #6801

merged 1 commit into from
Feb 11, 2022

Conversation

maciaszczykm
Copy link
Member

Restores strip ANSI functionality.

Closes #6774.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@maciaszczykm maciaszczykm mentioned this pull request Feb 10, 2022
Closed
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #6801 (a807e19) into master (fe4b5fc) will increase coverage by 0.12%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #6801      +/-   ##
==========================================
+ Coverage   41.49%   41.61%   +0.12%     
==========================================
  Files          44       44              
  Lines        1234     1228       -6     
  Branches      162      162              
==========================================
- Hits          512      511       -1     
+ Misses        722      717       -5

@floreks
Copy link
Member

floreks commented Feb 10, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

7 similar comments
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@maciaszczykm maciaszczykm added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 11, 2022
@maciaszczykm maciaszczykm merged commit 69a728e into kubernetes:master Feb 11, 2022
@maciaszczykm maciaszczykm deleted the fix-ansi branch February 11, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not all ansi is being stripped from logs
4 participants
@maciaszczykm @floreks @k8s-ci-robot @k8s-triage-robot