Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize graph values after determining the highest suffix in the whole dataset #6952

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Normalize graph values after determining the highest suffix in the whole dataset #6952

merged 1 commit into from
Apr 10, 2022

Conversation

jamesorlakin
Copy link
Contributor

I noticed the graphs have subtly incorrect normalizing behaviour if latter data points have a higher suffix. For example, crossing the Mi to Gi boundary results in the strange behaviour of the graph being in Gi but some values being unnormalized Mi:
Pre

This patch tweaks normalization to happen on all values after finding the suffix. It also tweaks the 'ballast' added to memory graphs so that the change between Mi and Gi is less jarring:
Post

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 2, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jamesorlakin / name: James Lakin (9ef7bf4)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 2, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @jamesorlakin!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2022
@k8s-ci-robot k8s-ci-robot requested review from jeefy and shu-mutou April 2, 2022 23:05
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 2, 2022
@floreks
Copy link
Member

floreks commented Apr 10, 2022

This totally makes more sense than the old version. Nice catch and fix! Thanks 🙂

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #6952 (9ef7bf4) into master (1a4f41b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #6952      +/-   ##
==========================================
+ Coverage   41.65%   41.68%   +0.03%     
==========================================
  Files          45       45              
  Lines        1234     1233       -1     
  Branches      163      163              
==========================================
  Hits          514      514              
+ Misses        720      719       -1     

@floreks
Copy link
Member

floreks commented Apr 10, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, jamesorlakin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 58f7b5d into kubernetes:master Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants