-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize graph values after determining the highest suffix in the whole dataset #6952
Normalize graph values after determining the highest suffix in the whole dataset #6952
Conversation
|
Welcome @jamesorlakin! |
This totally makes more sense than the old version. Nice catch and fix! Thanks 🙂 |
Codecov Report
@@ Coverage Diff @@
## master #6952 +/- ##
==========================================
+ Coverage 41.65% 41.68% +0.03%
==========================================
Files 45 45
Lines 1234 1233 -1
Branches 163 163
==========================================
Hits 514 514
+ Misses 720 719 -1 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floreks, jamesorlakin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I noticed the graphs have subtly incorrect normalizing behaviour if latter data points have a higher suffix. For example, crossing the Mi to Gi boundary results in the strange behaviour of the graph being in Gi but some values being unnormalized Mi:

This patch tweaks normalization to happen on all values after finding the suffix. It also tweaks the 'ballast' added to memory graphs so that the change between Mi and Gi is less jarring:
