Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling adjustments and fixes #7008

Merged
merged 9 commits into from
Apr 14, 2022
Merged

Styling adjustments and fixes #7008

merged 9 commits into from
Apr 14, 2022

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Apr 13, 2022 •
edited
Loading

@maciaszczykm
Multiple styling adjustments
273a69a 
Fix subscription leak
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from floreks and jeefy April 13, 2022 11:06
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022 •
edited
Loading

Codecov Report

Merging #7008 (159a402) into master (913a71a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7008   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          46       46           
  Lines        1279     1279           
  Branches      161      161           
=======================================
  Hits          564      564           
  Misses        715      715

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2022
@maciaszczykm
Copy link
Member Author

@floreks PTAL

@floreks
Copy link
Member

floreks commented Apr 14, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e8013ff into kubernetes:master Apr 14, 2022
@maciaszczykm maciaszczykm deleted the fixes branch April 19, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks Awaiting requested review from floreks

@jeefy jeefy Awaiting requested review from jeefy

Assignees

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/de Updates or issues for German translations. language/fr Updates or issues for French translations. language/ja Updates or issues for Japanese translations. language/ko Updates or issues for Korean translations. language/zh Updates or issues for Chinese translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource Actions hidden for smaller viewports
3 participants
@maciaszczykm @floreks @k8s-ci-robot