-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added additional rules option to role #7370
Conversation
|
Welcome @elizaitsev! |
Thanks! Could you bump minor version of chart in CharT.yaml, document the value in values.yaml? |
@floreks, could you trigger tests? |
@desaintmartin Done. |
Codecov Report
@@ Coverage Diff @@
## master #7370 +/- ##
=======================================
Coverage 44.22% 44.22%
=======================================
Files 46 46
Lines 1282 1282
Branches 178 178
=======================================
Hits 567 567
Misses 677 677
Partials 38 38 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, elizaitsev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I wanted to add an option to add additional rules to role, the same way clusterrole has it.
Issue: #7369