-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Secret with non-latin1 UTF-8 string #7412
fix: update Secret with non-latin1 UTF-8 string #7412
Conversation
|
Welcome @Senorsen! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Senorsen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ping @jeefy @shu-mutou for reviewing 😄 |
@Senorsen: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since #7047 has been merged and it introduces major architecture changes we should close this PR. If you are willing to work on it, you can open a new PR against the current master. /close |
@floreks: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR will fix #7411.
Currently, I implement the fix using a third-party library: js-base64, and its size seems okay (minified ~8kb without tree-shaking; total build size: original 251388kb -> after 251392kb, +4kb).
Another way is using the
unescape
andencodeURIComponent
trick:However, considered
unescape
is deprecated, maybe we should avoid using it. Am I right?