Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build updates #7478

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Build updates #7478

merged 3 commits into from
Sep 23, 2022

Conversation

floreks
Copy link
Member

@floreks floreks commented Sep 23, 2022

  • Move most "ensure" targets to the yarn postinstall
  • Properly install husky in a web dir (it works globally 🎉)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022 •
edited
Loading

Codecov Report

Merging #7478 (90ba839) into master (5d1383e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7478   +/-   ##
=======================================
  Coverage   42.27%   42.27%           
=======================================
  Files         220      220           
  Lines       12123    12123           
  Branches      179      179           
=======================================
  Hits         5125     5125           
  Misses       6714     6714           
  Partials      284      284

maciaszczykm
maciaszczykm approved these changes Sep 23, 2022
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d233e49 into kubernetes:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

Assignees

@maciaszczykm maciaszczykm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@floreks @k8s-ci-robot @maciaszczykm